Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Exa.TrkX link unit test MetricHooks #2683

Merged
merged 4 commits into from
Nov 17, 2023
Merged

test: Exa.TrkX link unit test MetricHooks #2683

merged 4 commits into from
Nov 17, 2023

Conversation

AJPfleger
Copy link
Contributor

The test was overlooked.

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2097b7a) 49.70% compared to head (eee4aba) 49.70%.
Report is 1 commits behind head on main.

❗ Current head eee4aba differs from pull request most recent head 68a73e8. Consider uploading reports for the commit 68a73e8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
- Coverage   49.70%   49.70%   -0.01%     
==========================================
  Files         474      474              
  Lines       26892    26884       -8     
  Branches    12376    12374       -2     
==========================================
- Hits        13368    13364       -4     
+ Misses       4710     4706       -4     
  Partials     8814     8814

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

📊: Physics performance monitoring for 68a73e8

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review November 16, 2023 18:01
@benjaminhuth benjaminhuth added this to the next milestone Nov 16, 2023
benjaminhuth
benjaminhuth approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kodiakhq kodiakhq bot merged commit fd1e0b4 into acts-project:main Nov 17, 2023
48 checks passed
@AJPfleger AJPfleger deleted the exatest branch November 17, 2023 18:16
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuth benjaminhuth benjaminhuth approved these changes

Assignees
No one assigned
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v31.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AJPfleger @benjaminhuth @paulgessinger